feat: show multi-threading in example #246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
238
to
248
| // If instead you were working in a multi-threaded context | ||
| // it might look like this | ||
| Runnable myThread = () -> { | ||
| for(int i = 0; i < 20; ++i) | ||
| QueryItemWithCompoundBeacon(ddb, ddbTableName); | ||
| }; | ||
| // increase once we expect threads to work | ||
| for(int i = 0; i < 1; ++i) { | ||
| Thread run = new Thread(myThread); | ||
| } | ||
| } |
There was a problem hiding this comment.
I think a thread pool would be cleaner here:
import java.util.concurrent.ExecutorService;
import java.util.concurrent.Executors;
...
MAX_CONCURRENT_QUERY_THREADS = 1;
Then,
Suggested change
| // If instead you were working in a multi-threaded context | |
| // it might look like this | |
| Runnable myThread = () -> { | |
| for(int i = 0; i < 20; ++i) | |
| QueryItemWithCompoundBeacon(ddb, ddbTableName); | |
| }; | |
| // increase once we expect threads to work | |
| for(int i = 0; i < 1; ++i) { | |
| Thread run = new Thread(myThread); | |
| } | |
| } | |
| // If instead you were working in a multi-threaded context | |
| // it might look like this | |
| Runnable myThread = () -> { | |
| for (int i = 0; i < 20; i++) { | |
| QueryItemWithCompoundBeacon(ddb, ddbTableName); | |
| } | |
| }; | |
| ExecutorService pool = Executors.newFixedThreadPool(MAX_CONCURRENT_QUERY_THREADS); | |
| for(int i = 0; i < MAX_CONCURRENT_QUERY_THREADS; i++) { | |
| pool.execute(myThread); | |
| } | |
| pool.shutDown(); |
We could also manage threads individually, but I think we would have to manage them in some data structure to ensure all threads join before we return success from the test, e.g.
Thread[] threads = new Thread[MAX_CONCURRENT_QUERY_THREADS];
// If instead you were working in a multi-threaded context
// it might look like this
Runnable myThread = () -> {
for(int i = 0; i < 20; i++)
QueryItemWithCompoundBeacon(ddb, ddbTableName);
};
// increase once we expect threads to work
for(int i = 0; i < MAX_CONCURRENT_QUERY_THREADS; i++) {
Thread run = new Thread(myThread);
threads[i] = run;
run.start();
}
for(int i = 0; i < MAX_CONCURRENT_QUERY_THREADS; i++) {
run.join()
}
lucasmcdonald3
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.